autocomplete: Put best matches near input field. #1131
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apoorvapendse
force-pushed
the
put-best-matches-near-fingers
branch
3 times, most recently
from
a146a49 to
bd3a205
Compare
PIG208
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Thanks for the PR @apoorvapendse! Left some comment.
This doesn't fix #1123 because the emoji picker (added in #1103) is a feature separate from autocompletion, so please update the PR comment and the commit message to reflect that.
| // biohazardOptionLabel, this won't be rendered in the list initally since it is the 7th option. | ||
| ]; | ||
|
|
||
| await tester.enterText(composeInputFinder, 'hi :'); |
There was a problem hiding this comment.
We need a comment here if it's also affected by #226.
apoorvapendse
force-pushed
the
put-best-matches-near-fingers
branch
from
bd3a205 to
129434b
Compare
This commit reverses the list that was originally presented to the user while showing the typeahead menu. This makes sense since on mobile its easier to click on options closer to the input box, i.e. where your fingers are currently present, instead of pressing arrow keys on a keyboard which is true on a desktop setup. Hence we place the best matching options not at the top of the typeahead menu, but instead put them at the bottom for better reachability and convenience of the user. Tests have been added to verify the emoji and mention render behavior. Fixes zulip#1121.
apoorvapendse
force-pushed
the
put-best-matches-near-fingers
branch
from
129434b to
b35ddbf
Compare
PIG208
reviewed
Dec 18, 2024
|
|
||
| final expectedUserSequence = users; | ||
| // Options are filtered correctly for query | ||
| // TODO(#226): Remove this extra edit when this bug is fixed. |
There was a problem hiding this comment.
In #1131 (comment), I was referring to this comment here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverses the list that was originally
presented to the user while showing the typeahead
menu.
This makes sense since on mobile its easier to click on options closer to the input box, i.e. where your fingers are currently present, instead of pressing arrow keys to navigate through the options on a keyboard which is convenient on a desktop setup.
Hence we place the best matching options not at the top of the typeahead menu, but instead at the bottom for better reachability and convenience of the user.
CZO
Fixes #1121.
Here is a demo:
Screencast from 12-11-2024 12:38:19 PM.webm